From dd5eeccf7adfeef295bfd82476eabe09cd9a38da Mon Sep 17 00:00:00 2001 From: DM Date: Sun, 8 Oct 2023 00:29:00 +0100 Subject: [PATCH] Tidy up --- dhcp/midasd.py | 1 - midas | 9 --------- 2 files changed, 10 deletions(-) diff --git a/dhcp/midasd.py b/dhcp/midasd.py index 927ea0a..c0d1c1e 100644 --- a/dhcp/midasd.py +++ b/dhcp/midasd.py @@ -305,7 +305,6 @@ class DHCPServer(object): self.DHCP_SERVER_PORT = self.SETTINGS['DHCP']['SERVER_PORT'] self.MAX_BYTES = self.SETTINGS['DHCP']['MAX_BYTES'] self.TFTP_SERVER_IP = self.SETTINGS['TFTP']['SERVER_IP'] - def create_socket(self): ''' diff --git a/midas b/midas index 6fe1e01..24648d8 100755 --- a/midas +++ b/midas @@ -13,12 +13,3 @@ if __name__ == '__main__': provisioning.render(topology) dhcp_server = DHCPServer(SETTINGS_FILE='settings.yaml') dhcp_server.run(topology) - -# Todo -# 1. Implement giaddr inspection as backup to packet source address, current using socket source IP instead - # Not needed? Adds further complexity and lines of code, socket already reports source IP address -# 2. Add fingerprints / persistent lease storage system (ensure that duplicate packets are only printed once, i.e. Cisco sends multiple release packets) -# 3. Work out what variables can be made more dynamic, i.e. reply packet options - build from a YAML file? -# 4. Make IP allocation & config var (YAML) generation automatic -# 5. Implement socket.inet_aton() function -# 6. PCAP from PC to capture DHCP option values that are not yet printed in a human readable format